extproc: remove the path from the translator factory #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nacx
changed the title
mathetake
reviewed
Feb 12, 2025
| // - `l`: the logger. | ||
| type Factory func(path string) (Translator, error) | ||
| // Factory creates a [Translator] for the given API schema combination. | ||
| type Factory func() Translator | ||
|
|
||
| // NewFactory returns a callback function that creates a translator for the given API schema combination. | ||
| func NewFactory(in, out filterapi.VersionedAPISchema) (Factory, error) { |
There was a problem hiding this comment.
should we now rename this to NewChatCompletionTranslatorFactory ?
There was a problem hiding this comment.
I've completely removed the Factory now, and moved the translator instantiation to the chat completion processor, as it does only make sense for that processor.
WDYT?
|
coverage! |
nacx
force-pushed
the
cleanup-translator-factory
branch
from
c3a1722 to
916b0bf
Compare
mathetake
reviewed
Feb 13, 2025
Signed-off-by: Ignasi Barrera <[email protected]>
Signed-off-by: Ignasi Barrera <[email protected]>
Signed-off-by: Ignasi Barrera <[email protected]>
Signed-off-by: Ignasi Barrera <[email protected]>
nacx
force-pushed
the
cleanup-translator-factory
branch
from
916b0bf to
bbfdc4e
Compare
mathetake
reviewed
Feb 13, 2025
| } | ||
| return nil, fmt.Errorf("unsupported path: %s", path) | ||
| // NewOpenAIToAWSBedrockTranslator implements [Factory] for OpenAI to AWS Bedrock translation. | ||
| func NewOpenAIToAWSBedrockTranslator() Translator { |
Signed-off-by: Ignasi Barrera <[email protected]>
mathetake
reviewed
Feb 13, 2025
mathetake
approved these changes
Feb 13, 2025
mathetake
added a commit
that referenced
this pull request
Feb 18, 2025
**Commit Message** extproc: decouple router package from api paths This is a follow-up change to decouple the router package from the API paths. Now that we have specialized processors per API path it does not make sense for the router package to have path-related logic. Now each processor is responsible for instantiating the right body parser for the path they're processing. **Related Issues/PRs (if applicable)** Follow-up for #325 and #334 **Special notes for reviewers (if applicable)** N/A --------- Signed-off-by: Ignasi Barrera <[email protected]> Co-authored-by: Takeshi Yoneda <[email protected]>
daixiang0
pushed a commit
to daixiang0/ai-gateway
that referenced
this pull request
Feb 19, 2025
**Commit Message** extproc: remove the path from the translator factory Removes the path from the translator factory, now that there is a dedicated processor for the chat completion endpoint. **Related Issues/PRs (if applicable)** Follow-up for: envoyproxy#325 (review) **Special notes for reviewers (if applicable)** Note that I don't remove the `Factory` type completely so that only the right translator is instantiated and only when needed. --------- Signed-off-by: Ignasi Barrera <[email protected]> Signed-off-by: Loong <[email protected]>
daixiang0
pushed a commit
to daixiang0/ai-gateway
that referenced
this pull request
Feb 19, 2025
**Commit Message** extproc: decouple router package from api paths This is a follow-up change to decouple the router package from the API paths. Now that we have specialized processors per API path it does not make sense for the router package to have path-related logic. Now each processor is responsible for instantiating the right body parser for the path they're processing. **Related Issues/PRs (if applicable)** Follow-up for envoyproxy#325 and envoyproxy#334 **Special notes for reviewers (if applicable)** N/A --------- Signed-off-by: Ignasi Barrera <[email protected]> Co-authored-by: Takeshi Yoneda <[email protected]> Signed-off-by: Loong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message
extproc: remove the path from the translator factory
Removes the path from the translator factory, now that there is a dedicated processor for the chat completion endpoint.
Related Issues/PRs (if applicable)
Follow-up for: #325 (review)
Special notes for reviewers (if applicable)
Note that I don't remove the
Factorytype completely so that only the right translator is instantiated and only when needed.